Conversation
Contributor
tangtan2
commented
Apr 7, 2026
tangtan2
commented
- add new API to SDK/CLI
tangtan2
requested review from
makk94,
packplusplus and
stephanwampouille
as code owners
packplusplus
approved these changes
Apr 7, 2026
| "--limit", default=100, help="maximum number of results to return", type=int | ||
| ) | ||
| @click.option("--offset", default=0, help="number of results to skip", type=int) | ||
| @click.option("--odata_filter", help="OData filter string") |
Contributor
Author
There was a problem hiding this comment.
this is the order in all of the other list functions!!!! im not gonna change it im sorry
| "$skip": skip, | ||
| } | ||
|
|
||
| res = self.get(f"{self.account.hq}/scm/software", params=params, timeout=30) |
Contributor
There was a problem hiding this comment.
api will timeout before this right?
Contributor
Author
There was a problem hiding this comment.
yeah we have a bunch of timeout=30 throughout the sdk, is that good or is it better to make it shorter than the api timeout?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.