Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for automatic Pull Request creation to the update-gradle-wrapper action, allowing it to commit and create PRs with Gradle wrapper updates automatically when configured.
Key changes:
- Adds
create-prandtokeninputs to enable optional automatic PR creation - Adds
gradle-versionoutput to expose the resolved Gradle version (useful for PR titles/branches) - Updates the wrapper update process to run
gradlew wrappertwice to ensure all files are properly regenerated - Updates test workflow to use the new PR creation feature with GitHub App token
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
update-gradle-wrapper/update-gradle-wrapper.sh |
Adds double wrapper execution for complete file regeneration and outputs the resolved gradle-version |
update-gradle-wrapper/action.yml |
Adds create-pr and token inputs, gradle-version output, and integrates peter-evans/create-pull-request action |
update-gradle-wrapper/README.md |
Adds comprehensive documentation for the new PR creation feature with examples and updated requirements |
.github/workflows/test-update-gradle-wrapper.yml |
Updates test workflow to demonstrate PR creation feature with GitHub App token authentication |
| name: Test Update Gradle Wrapper Action | ||
|
|
||
| 'on': | ||
| on: |
There was a problem hiding this comment.
The workflow file should use 'on': (with quotes) instead of on: to be consistent with the repository's YAML style convention. Other workflow files in this repository (test.yml, test-shell.yml, and release.yml) all use the quoted format 'on': to avoid yamllint truthy warnings.
Suggested change
| on: | |
| 'on': |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.