Skip to content

Update krew plugin to consume previous pod logs if available #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonymeehan merged 1 commit into from
Jun 4, 2025
Merged

Update krew plugin to consume previous pod logs if available #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions cmd/plugin/krew/krew.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,30 +328,31 @@ func redirectConfigMap(ctx context.Context, clientset *kubernetes.Clientset, nam
}

func redirectPodLogs(ctx context.Context, clientset *kubernetes.Clientset, namespace, pod string) error {

var (
rdr io.ReadCloser
err error
)

rdr, err = clientset.CoreV1().Pods(namespace).GetLogs(pod, &v1.PodLogOptions{}).Stream(ctx)
if err != nil {
return err
}

pr, pw, err := os.Pipe()
if err != nil {
return err
}

go func() {
defer pw.Close()
if _, err := io.Copy(pw, rdr); err != nil {
log.Warn().Err(err).Msg("copy logs -> pipe failed")

if prev, err := clientset.CoreV1().
Pods(namespace).
GetLogs(pod, &v1.PodLogOptions{Previous: true}).
Stream(ctx); err == nil {
_, _ = io.Copy(pw, prev) // best-effort copy
_ = prev.Close()
}

if curr, err := clientset.CoreV1().
Pods(namespace).
GetLogs(pod, &v1.PodLogOptions{}).
Stream(ctx); err == nil {
_, _ = io.Copy(pw, curr)
_ = curr.Close()
}
}()

os.Stdin = pr

return cli.InitAndExecute(ctx)
}