Provide ARM support for docker-compose#358
Conversation
|
What's the hold up on this PR? |
|
|
|
Would love to see this PR merged. fyi @ParmuSingh looks like a few conflicts now. |
|
Hello @ParmuSingh, Thanks for the ARM support effort! A few notes before we merge this in: 1. Build Platform & Dockerfile Alignment
2. The Main Blocker: Architecture-Specific AssetsThe main blocker right now isn't the compose file, but the Docker build itself. The build currently always downloads To support ARM64 dynamically, we need to map the Docker build architecture (
This can be elegantly handled directly inside the ARG TARGETARCH
# Map Docker architecture strings to our specific asset filenames
RUN if [ "$TARGETARCH" = "amd64" ]; then \
echo "X64" > /tmp/arch && echo "x64" > /tmp/config; \
elif [ "$TARGETARCH" = "arm64" ]; then \
echo "ARM64" > /tmp/arch && echo "arm64" > /tmp/config; \
fi
# Dynamically download the exact matching zip archive
RUN ARCH_SUFFIX=$(cat /tmp/arch) && \
curl -L -O "[https://github.com/.../export-Linux-$](https://github.com/.../export-Linux-$){ARCH_SUFFIX}.zip"I'm happy to collaborate on this! We could break this down into a smaller, more focused PR that only touches the sync script / download logic, Dockerfile, and README first. Let me know what you think. |
Hey - I was using presentonAI and I found out that the generic docker image is compiled for x86_64 arch CPUs.
I've created PR to add support for arm64 architecture CPUs as well.
Please feel free to modify the PR as you wish for better compatibility with your project.
Thanks for the open source contribution!