[WIP] Thrift migration for TaskStatus #24752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@vhsu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shangm2
force-pushed
the
task_status_thrift
branch
2 times, most recently
from
2b0feed to
ee16523
Compare
Collaborator
|
@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shangm2
force-pushed
the
task_status_thrift
branch
from
ee16523 to
db26ced
Compare
Collaborator
|
@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
6 tasks
shangm2
force-pushed
the
task_status_thrift
branch
from
db26ced to
480d9db
Compare
Collaborator
|
@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shangm2
force-pushed
the
task_status_thrift
branch
3 times, most recently
from
efcec75 to
a12fb75
Compare
Collaborator
|
@vhsu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
@shangm2 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shangm2
force-pushed
the
task_status_thrift
branch
2 times, most recently
from
c96f4dd to
e11eaa8
Compare
shangm2
force-pushed
the
task_status_thrift
branch
from
e11eaa8 to
9f3e58e
Compare
shangm2
commented
Apr 23, 2025
| throw new RuntimeException("Thrift request failed with response code " + response.getStatusCode()); | ||
| } | ||
|
|
||
| byte[] responseBody = readResponseBytes(response); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: