-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add Hive Parquet ZSTD compression support #24761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Suggest adding a mention of ZSTD as an option for |
@steveburnett Thanks for the comment. I think we can add |
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks for adding the doc!
yingsu00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please
- Add ZSTD to the benchmarks com/facebook/presto/hive/benchmark/HiveFileFormatBenchmark.java and put the result in the PR message
- Add compression codecs to test com/facebook/presto/hive/TestHivePageSink.java
|
@steveburnett @yingsu00 Thanks for the comment! Will add it |
Description
This PR adds ZSTD compression support for Hive Parquet.
Motivation and Context
Impact
Test Plan
hive.compression-codec=zstdto the hive catalog fileBefore the change, an error
ZSTD compression is not supported with PARQUETwas reported. Now there's no error and when usingparquet-toolsto inspect the file, we can seecompression: ZSTDAlso verified it with
presto-native-executionContributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.