Skip to content

Conversation

@sdruzkin
Copy link
Collaborator

@sdruzkin sdruzkin commented Apr 10, 2025

Description

Remove Nimble file format references from Java OSS.

Differential Revision: D72808755

Motivation and Context

Not needed in Java OSS.

Impact

No impact.

Test Plan

It builds.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@sdruzkin sdruzkin requested a review from a team as a code owner April 10, 2025 18:59
@sdruzkin sdruzkin requested a review from presto-oss April 10, 2025 18:59
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Apr 10, 2025
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D72808755

@jaystarshot
Copy link
Member

Is nimble project being shut down?

sdruzkin added a commit to sdruzkin/presto that referenced this pull request Apr 10, 2025
Summary:

Remove Nimble file format references from Java OSS since we now have a dup
of the presto-hive modules.

Differential Revision: D72808755
@sdruzkin
Copy link
Collaborator Author

Is nimble project being shut down?

No, Nimble is doing great and is going to replace DWRF in our DWH soon. We just don't need integration with Java OSS at this moment and I wanted to clean up stuff that is not used.

@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D72808755

sdruzkin added a commit to sdruzkin/presto that referenced this pull request Apr 10, 2025
Summary:
Pull Request resolved: prestodb#24903

Remove Nimble file format references from Java OSS since we now have a dup
of the presto-hive modules.

Differential Revision: D72808755
sdruzkin added a commit to sdruzkin/presto that referenced this pull request Apr 11, 2025
Summary:

Remove Nimble file format references from Java OSS since we now have a dup
of the presto-hive modules.

Differential Revision: D72808755
Summary:
Pull Request resolved: prestodb#24903

Remove Nimble file format references from Java OSS since we now have a dup
of the presto-hive modules.

Differential Revision: D72808755
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D72808755

@sdruzkin
Copy link
Collaborator Author

Unrelated test keep failing:

TestResourceManagerClusterStatusSender.testQueryHeartbeat:140 expected [true] but found [false]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants