[iceberg] Add metrics reporter for iceberg table scans

[j-sund]

Description

Adds a new MetricsReporter implementation to propagate Iceberg table scan metrics into session RuntimeStats

Motivation and Context

Exposing these metrics can improve query observability, which thus makes future improvements to the Iceberg integration a little easier. This also enables better performance monitoring.

Impact

Allows for better visibility into the Iceberg integration.

Test Plan

Ensure the metric is visible and being populated. Basic tests are included in IcebergDistributedSmokeTestBase.java class

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• [] Adequate tests were added if applicable.
• CI passed.

Release Notes

== NO RELEASE NOTE ==

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: j-sund / name: Joshua Sundararaman (f09e109)

[ZacBlanco]

@j-sund Can you sign the CLA using the link in the comment above? You can just sign as a personal contributor.

Also, before your next push try running ./mvnw validate -pl presto-iceberg to ensure your code passes all the checkstyle and license rules. I see the maven checks / maven-checks CI action is failing with the following:

Warning:  Missing header in: /home/runner/work/presto/presto/presto-iceberg/src/main/java/com/facebook/presto/iceberg/RuntimeStatsMetricsReporter.java

[ZacBlanco]

Just minor things. This looks great!

[hantangwangd]

This looks like a great feature! Some nits, and a minor problem in the test code.

[hantangwangd]

I have submit a PR #25140 to make sure that the table name loaded from all catalogs have consistent formatting <catalog>.<schema>.<table>. So I think after that change being merged, we can use the following code to build table name uniformly:

        String catalog = getSession().getCatalog().get();
        String schema = getSession().getSchema().get();
        String tableName = catalog + "." + schema + ".orders";

[hantangwangd]

Hi @j-sund, since PR #25140 has been merged, you can rebase to include the change. This enables a consistent way to build the table name as described above.

[ZacBlanco]

Just a few style nits. Otherwise LGTM! Can you also squash all of your commits into one?

[ZacBlanco]

LGTM! Can you please squash all of your commits into one? Also, try to write a descriptive commit title+message

[hantangwangd]

Thanks for the fix, LGTM.

[steveburnett]

@j-sund, there have been some fixes to the CI tests since the last activity on this PR. If you rebase, these pending tests might pass.

[j-sund]

@steveburnett

maven check failure unable to run 'yarn' for presto-ui.

not sure if this was just a mishap with the github CI runner? My code shouldn't have affected the presto-ui.

Any insight would be appreciated.

[hantangwangd]

Looks like occasional failures, fixed by a rerun.

Hi @ZacBlanco, do you have any more comments? If not, I think this PR is ready to be merged.

[steveburnett]

@steveburnett

maven check failure unable to run 'yarn' for presto-ui.

not sure if this was just a mishap with the github CI runner? My code shouldn't have affected the presto-ui.

Any insight would be appreciated.

A rerun seems to have worked, at this time I'm seeing "All checks have passed / 108 successful checks".

[j-sund]

@hantangwangd I wanted to check the status of this long standing pr. Im not sure if Zac is an active iceberg maintainer anymore

There has been no response for a considerable period of time.

[hantangwangd]

@j-sund Sorry for the delay of merging. Following the lazy consensus mentioned by @tdcmeehan here, I dismissed ZacBlanco's review. And will merge the PR tomorrow if there are no further objections.