Make EquiJoinClause fields in IndexJoinNode compatible with protocol

[zacw7]

== NO RELEASE NOTE ==

[aditi-pandit]

@zacw7 : Do you have to regenerate presto_protocol for native engine for this as well ? Can you check ?

[zacw7]

@zacw7 : Do you have to regenerate presto_protocol for native engine for this as well ? Can you check ?

No we don't have to. It's already part of the protocol.

[aditi-pandit]

@zacw7 : Do you have to regenerate presto_protocol for native engine for this as well ? Can you check ?

No we don't have to. It's already part of the protocol.

@zacw7 : But do the json field names change by any chance ? I would expect the generated code to be slightly different.

[zacw7]

@zacw7 : Do you have to regenerate presto_protocol for native engine for this as well ? Can you check ?

No we don't have to. It's already part of the protocol.

@zacw7 : But do the json field names change by any chance ? I would expect the generated code to be slightly different.

This change doesn't introduce anything new. EquiJoinClause is already part of protocol with fields names "left" and "right".

presto/presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.h

Lines 1263 to 1266 in 7820553

	struct EquiJoinClause {
	VariableReferenceExpression left = {};
	VariableReferenceExpression right = {};
	};

The protocol is expecting "left" and "right" while in IndexJoinNode they are currently named as "probe" and "index" which would cause issue.

[xiaoxmeng]

@zacw7 thanks!

[aditi-pandit]

@zacw7 : Do you have to regenerate presto_protocol for native engine for this as well ? Can you check ?

No we don't have to. It's already part of the protocol.

@zacw7 : But do the json field names change by any chance ? I would expect the generated code to be slightly different.

This change doesn't introduce anything new. EquiJoinClause is already part of protocol with fields names "left" and "right".

presto/presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.h

Lines 1263 to 1266 in 7820553

	struct EquiJoinClause {
	VariableReferenceExpression left = {};
	VariableReferenceExpression right = {};
	};

The protocol is expecting "left" and "right" while in IndexJoinNode they are currently named as "probe" and "index" which would cause issue.

@zacw7 : Thanks for explaining to me. Now your PR title seems more understandable as well.