Skip to content

Add release maven artifacts github action#5

Merged
ZacBlanco merged 1 commit into
prestodb:masterfrom
unidevel:add_release_action
May 15, 2025
Merged

Add release maven artifacts github action#5
ZacBlanco merged 1 commit into
prestodb:masterfrom
unidevel:add_release_action

Conversation

@unidevel
Copy link
Copy Markdown

@unidevel unidevel commented May 8, 2025

To make the release action work, we need set the version as snapshot version e.g. 1.8-SNAPSHOT.

mvn versions:set -DnewVersion=1.8-SNAPSHOT

Tested with => https://github.com/unix280/resolver/actions/runs/14908389433/job/41876272389

@ZacBlanco
Copy link
Copy Markdown

@unidevel I just merged #4 which fixes the parent namespace and version. Can you check that this still works when you publish in your fork with the latest updates?

@unidevel
Copy link
Copy Markdown
Author

unidevel commented May 8, 2025

@ZacBlanco There is typo in the pom.xml, should be 1.7-SNAPSHOT

<version>1.7-SNASPSHOT</version>

All the 3 pom.xml need to be changed

@aaneja
Copy link
Copy Markdown

aaneja commented May 8, 2025

#6 fixes the typo

@ZacBlanco
Copy link
Copy Markdown

It is merged now

@unidevel
Copy link
Copy Markdown
Author

unidevel commented May 8, 2025

I tested, seems the action is fine except the publishing will fail with error 401 as expected

@unidevel
Copy link
Copy Markdown
Author

unidevel commented May 8, 2025

@ZacBlanco I don't have the permission to merge, but we can keep it open until we want to publish a release. I had already set up the action environment, all the variables and secrets, require presto-committer to approve the action when running.

@ZacBlanco
Copy link
Copy Markdown

Sounds good. When we are ready to release I will get the ball rolling on this

@ZacBlanco ZacBlanco merged commit 8bba281 into prestodb:master May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants