Document windowing functions#480
Merged
Merged
Conversation
SethBarberee
approved these changes
May 1, 2026
Kermalis
reviewed
May 6, 2026
| } | ||
| else { | ||
| sub_8005838(0, 5); | ||
| CopyWindowBgBuffer(0, 5); |
| sp[2] = room->unk14 - strPtr->cameraPixelPos.x; | ||
| sp[3] = room->unk18 - strPtr->cameraPixelPos.y; | ||
| sub_8005838(sp, 3); | ||
| CopyWindowBgBuffer(sp, 3); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and document functions to handle GBA windows.
Looks like in addition to the normal menu and text box windows using WIN0, GBA windows are also used to dim the screen in dungeons with low visibility with WIN1. Windows dimensions can be changed per row, DMA writes to the window registers every HBlank. There is also a double buffering system going on when setting up the DMA presumably to prevent modifying the data while DMA is copying it.