PHP 8.1 - match is formatted into one line if the whole block is short enough - which is weird

[AndreasA]

If the used match with not a lot of content, it is formatted as one line which is really tricky to read.

Prettier 2.6.2

PHP Plugin 0.18.4

{
  "printWidth": 80,
  "tabWidth": 4,
  "useTabs": false,
  "singleQuote": true,
  "phpVersion": "8.1",
  "trailingCommaPHP": true,
  "braceStyle": "psr-2",
  "requirePragma": false,
  "insertPragma": false
}

Input:

<?php declare(strict_types=1);

match ($case) { 
     'foo' => ['bar'], 
     'cd' => [],
     default => [],
};

Output:

<?php declare(strict_types=1);

match ($case) { 'foo' => ['bar'],  'cd' => [],  default => [] };

Expected behavior:

To be formatted as it was with input, to put each "case" in a new line.

Playground sample

[czosel]

Totally agree, thanks for reporting @AndreasA. The fix for this is potentially quite simple (replace „line“ with „hardline“) at the right place), so I marked it as „good first issue“. If anyone is interested to contribute and needs further support, let me know.

[AndreasA]

@czosel I think this https://github.com/prettier/plugin-php/pull/1994/files should fix it? Hopefully, it was the correct place. It probably does not fix #1965 though (but that one isn't that important).

Though I think the nested one looks weird https://github.com/prettier/plugin-php/pull/1994/files#diff-1c3a3001d3d77223dadd276e13c98b91eaaab6ca86301e0bd0a22f83e21ed07dR70
as the nested match seems to not be intended correctly? Can this be easily fixed? Though I am not sure this is actually part of this issue and not a separate issue (or maybe just a different config from what I am used).

[czosel]

@AndreasA I also noticed that nested match looks a bit strange. The fix should be relatively simple, see how indent is used in the printer. We can do this in a separate PR, though.

Fixed in v0.18.7 🎉