Skip to content

fix: insert pragma when first docblock mid-file (#1310)#1311

Merged
czosel merged 1 commit intoprettier:masterfrom
leighman:master
Feb 19, 2020
Merged

fix: insert pragma when first docblock mid-file (#1310)#1311
czosel merged 1 commit intoprettier:masterfrom
leighman:master

Conversation

@leighman
Copy link
Copy Markdown
Contributor

Thought I'd give it a try. No idea if this is sane.

@leighman
Copy link
Copy Markdown
Contributor Author

@czosel since you seem to be around and this is blocking us using the plugin. Sorry if you're not right to review this.

Copy link
Copy Markdown
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Sorry about the late reply and thanks for the contribution!

@czosel czosel merged commit 6a5cbe7 into prettier:master Feb 19, 2020
@czosel
Copy link
Copy Markdown
Collaborator

czosel commented Feb 19, 2020

Unfortunately we can't cut a release from the current master branch yet because some changes still have to land related to #1280. Let me know you'd like a 0.12.1 release with this feature cherry-picked from the last release.

@leighman
Copy link
Copy Markdown
Contributor Author

Thanks. Definitely wouldn't say no to a 0.12.1 ;)

@czosel
Copy link
Copy Markdown
Collaborator

czosel commented Feb 20, 2020

Just released this as part of 0.13.0 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants