fix: don't duplicate php8 attributes #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
not sure why CI is failing ... |
Member
|
bug in node.js |
fernando-rivas-smtp
approved these changes
Sep 8, 2021
|
maybe re running the ci? |
Collaborator
Author
|
@fernando-rivas-smtp doesn't seem to help … |
Member
|
@czosel Very weird, let's try to update deps |
Member
Member
|
Bug even in V8 |
Collaborator
Author
|
@alexander-akait wow, interesting! Shall we merge anyway for now, since "only" our test suite seems to be affected? |
Member
|
@czosel I think we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1820