Exapand "encapsed" support#2
Merged
vjeux merged 2 commits intoprettier:masterfrom Dec 25, 2017
Merged
Conversation
Contributor
|
I know the parser doesn't fully handle the curly's - should we just comment out that test case or something for now? would be good to keep the tests passing if we can |
Member
Contributor
|
What we've done for prettier is to keep those as github issues. Committing code that's not working is usually a bad idea: people get confused as to why it's there and not working. |
Support for curly syntax is not complete - see glayzzle/php-parser#101
because missing curly support makes AST comparison fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for curly syntax is not complete - see
glayzzle/php-parser#101