check for node_modules and package.json instead of VCS#89
Conversation
|
i imagine the reason it checked for for example, you could run it globally ( so i wonder if we should do both? |
|
fair point, I didn't think of that. I re-added the previous statements, so the PR is now just adding checks for |
|
@fabiospampinato can you also take a look at this? 2nd pair of eyes would be good but seems simple enough |
|
I ran into the same issue too, Any update ? The fix looks good. |
If we change the project root to be the first `package.json` / `node_modules` we see, we break monorepo traversal for things other than the cache. Really, we just need the cache dir to end up in the first `node_modules` we see, without affecting all other traversal. For this reason, this separates the two into a `cacheRootPath` and a `rootPath`. The former is only used for the cache, and the latter is used for everything else.
|
i've reworked this because it was unsafe to change the project root. here's the summary from the commit message: If we change the project root to be the first Really, we just need the cache dir to end up in the first For this reason, this separates the two into a |
Hi,
I also ran into the issue described in #80.
As suggested here, instead of searching for any VCS, we check for the first
node_modulesor apackage.json