Keep trailing-comma for var function#13402
Merged
sosukesuzuki merged 4 commits intoprettier:nextfrom Aug 30, 2022
Merged
Conversation
sosukesuzuki
commented
Aug 30, 2022
Comment on lines
+920
to
+927
| const hasComma = () => | ||
| Boolean( | ||
| child.source && | ||
| options.originalText | ||
| .slice(locStart(child), locStart(node.close)) | ||
| .trimEnd() | ||
| .endsWith(",") | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Ideally we need to use getNextNonSpaceNonCommentCharacterIndexWithStartIndex like this:
const hasComma = () => {
const index =
child &&
getNextNonSpaceNonCommentCharacterIndexWithStartIndex(
options.originalText,
locEnd(child)
);
return index && options.originalText[index] === ",";
};But, locEnd for --baz in var(--baz,) returns unexpected value
Member
There was a problem hiding this comment.
Because the location info is like a mess in this parser.
fisker
approved these changes
Aug 30, 2022
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 31, 2024
* Keep trailing-comma for last el * Make hasComma function * Fix tests * Add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13202
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨