fix: splitting jsx text correctly#5006
Merged
lydell merged 3 commits intoprettier:masterfrom Sep 2, 2018
Merged
Conversation
lydell
reviewed
Sep 2, 2018
| after | ||
| {stuff} | ||
| after | ||
| {stuff}after{stuff}after |
Member
There was a problem hiding this comment.
Why is there one line with only a single {stuff} in it? This is a weird edge case so it doesn’t matter much, but I’d like to understand how things work.
Contributor
Author
There was a problem hiding this comment.
Because we have three jsx expressins one after another. The same here
Contributor
Author
There was a problem hiding this comment.
We don't wrap text without space before/after jsx expression, but we wrap multiple jsx expressions, don't we?
Member
|
Thank you very much for doing this and sorry for the delay! |
lock
bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4941
docs/directory)