New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: splitting jsx text correctly #5006

Merged
merged 3 commits into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@yuliaHope
Contributor

yuliaHope commented Aug 22, 2018

Fixes: #4941

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Yuliya Haluza and others added some commits Aug 9, 2018

after
{stuff}
after
{stuff}after{stuff}after

This comment has been minimized.

@lydell

lydell Sep 2, 2018

Collaborator

Why is there one line with only a single {stuff} in it? This is a weird edge case so it doesn’t matter much, but I’d like to understand how things work.

This comment has been minimized.

@yuliaHope

yuliaHope Sep 2, 2018

Contributor

Because we have three jsx expressins one after another. The same here

This comment has been minimized.

@yuliaHope

yuliaHope Sep 2, 2018

Contributor

We don't wrap text without space before/after jsx expression, but we wrap multiple jsx expressions, don't we?

This comment has been minimized.

@lydell

lydell Sep 2, 2018

Collaborator

Ah, now I get it. Makes sense! 👍

@lydell lydell merged commit 0c7c1bf into prettier:master Sep 2, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.48% (+<.01%) compared to 58d34bb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@lydell

This comment has been minimized.

Collaborator

lydell commented Sep 2, 2018

Thank you very much for doing this and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment