New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add printer.preprocess #5041

Merged
merged 9 commits into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@ikatyang
Member

ikatyang commented Sep 1, 2018

Sometimes we need to transform the ast to make it easier to print, but it's currently done in the parser (markdown and yaml), which leads the output ast harder to use for external users (custom parser), adding printer.preprocess can solve this issue.

And also this way we could move the trailing newline for json from ast-to-doc.js to language-js.


  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@suchipi

This comment has been minimized.

Member

suchipi commented Sep 1, 2018

When a user uses a custom parser function, do we call preprocess before or after their function?

@ikatyang

This comment has been minimized.

Member

ikatyang commented Sep 1, 2018

text -> parser.preprocess -> parser (custom parser) -> printer.preprocess -> printer

@suchipi

suchipi approved these changes Sep 1, 2018

@ikatyang ikatyang merged commit 50c9115 into prettier:master Sep 3, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 99.2% of diff hit (target 80%)
Details
codecov/project 96.55% (+0.01%) compared to 6288704
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:feat/printer-preprocess branch Sep 3, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment