New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): no-semi for class props with modifiers #5083

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@ikatyang
Member

ikatyang commented Sep 12, 2018

Fixes #5082


Prettier pr-5083
Playground link

--parser typescript
--no-semi

Input:

const kBuffer = Symbol('buffer')
const kOffset = Symbol('offset')

class Reader {
  private [kBuffer]: Buffer // <-- here
  private [kOffset]: number
}

Output:

const kBuffer = Symbol("buffer")
const kOffset = Symbol("offset")

class Reader {
  private [kBuffer]: Buffer // <-- here
  private [kOffset]: number
}

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@j-f1

j-f1 approved these changes Sep 12, 2018

@ikatyang ikatyang merged commit f7a6625 into prettier:master Sep 13, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.25% (+<.01%) compared to b020a56
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/unnecessary-semi branch Sep 13, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment