Skip to content

fix(typescript): no-semi for class props with modifiers#5083

Merged
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/typescript/unnecessary-semi
Sep 13, 2018
Merged

fix(typescript): no-semi for class props with modifiers#5083
ikatyang merged 2 commits intoprettier:masterfrom
ikatyang:fix/typescript/unnecessary-semi

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Sep 12, 2018

Fixes #5082


Prettier pr-5083
Playground link

--parser typescript
--no-semi

Input:

const kBuffer = Symbol('buffer')
const kOffset = Symbol('offset')

class Reader {
  private [kBuffer]: Buffer // <-- here
  private [kOffset]: number
}

Output:

const kBuffer = Symbol("buffer")
const kOffset = Symbol("offset")

class Reader {
  private [kBuffer]: Buffer // <-- here
  private [kOffset]: number
}

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang merged commit f7a6625 into prettier:master Sep 13, 2018
@ikatyang ikatyang deleted the fix/typescript/unnecessary-semi branch September 13, 2018 03:14
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants