Escape not just backticks but ${ as well in graphql tags#5137
Merged
lydell merged 2 commits intoprettier:masterfrom Sep 29, 2018
Merged
Escape not just backticks but ${ as well in graphql tags#5137lydell merged 2 commits intoprettier:masterfrom
${ as well in graphql tags#5137lydell merged 2 commits intoprettier:masterfrom
Conversation
lydell
commented
Sep 23, 2018
| "Pattern: \\\`\\\${project}\\\`" | ||
| pattern: String | ||
| # Or escaping the first and second parentheses... | ||
| "Pattern: \\\`\\\${project}\\\`" |
Member
Author
There was a problem hiding this comment.
The original escaping here is lost, but that’s another issue.
Member
Author
|
Still seems to fail somehow :( Prettier pr-5137 --parser babylonInput: gql`
query {
a(c: "a \\ b ") {
b
}
}
`Output: SyntaxError: Syntax Error: Invalid character escape sequence: \ . (3:10)
1 |
2 | query {
> 3 | a(c: "a \ b ") {
| ^
4 | b
5 | }
6 | }EDIT: No, I'm just confused. The above is supposed to fail. Here's what I meant: Prettier pr-5137 --parser babylonInput: gql`
query {
a(c: "a \\\\ b ") {
b
}
}
`Output: gql`
query {
a(c: "a \\\\ b ") {
b
}
}
`;I'm starting to hate escaping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4974.
docs/directory)