Skip to content

Fix flow extends not breaking out into new lines#5244

Merged
j-f1 merged 1 commit intoprettier:masterfrom
aquibm:flow-multi-line-extends
Oct 25, 2018
Merged

Fix flow extends not breaking out into new lines#5244
j-f1 merged 1 commit intoprettier:masterfrom
aquibm:flow-multi-line-extends

Conversation

@aquibm
Copy link
Copy Markdown
Contributor

@aquibm aquibm commented Oct 11, 2018

Fixes #4944 by listing each interface declaration on a seperate line.

This is my first contribution to prettier, still trying to wrap my head around the codebase and commands. Please let me know if I've done anything wrong.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as temporary solution. Look #5156

@aquibm
Copy link
Copy Markdown
Contributor Author

aquibm commented Oct 16, 2018

Hey @evilebottnawi, would you like me to amend my PR to use a similar implementation as the PHP plugin?

@j-f1 j-f1 merged commit 1234ceb into prettier:master Oct 25, 2018
@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Oct 25, 2018

Thanks for contributing!

ikatyang added a commit to ikatyang/prettier that referenced this pull request Oct 25, 2018
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants