Skip to content

[TS] keep a pair of parentheses where there extra pairs.#6131

Merged
duailibe merged 5 commits intoprettier:masterfrom
sosukesuzuki:fix-6111
May 17, 2019
Merged

[TS] keep a pair of parentheses where there extra pairs.#6131
duailibe merged 5 commits intoprettier:masterfrom
sosukesuzuki:fix-6111

Conversation

@sosukesuzuki
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki commented May 17, 2019

Fix #6111
Previously, Prettier removes the necessary parentheses when trying to remove unnecessary parentheses, in TypeScript. So, I fixed to keep a pair of parentheses.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@sosukesuzuki
Copy link
Copy Markdown
Contributor Author

sosukesuzuki commented May 17, 2019 •
edited
Loading

@evilebottnawi
Codecov on CI is failed...
I don't know how to fix it.. Where should I add tests?

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented May 17, 2019

hm, ignore this, sometimes it happens

@sosukesuzuki
Copy link
Copy Markdown
Contributor Author

sosukesuzuki commented May 17, 2019

Okay, Thanks

@duailibe duailibe merged commit 4c64f13 into prettier:master May 17, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
@sosukesuzuki sosukesuzuki deleted the fix-6111 branch September 15, 2019 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@duailibe duailibe duailibe approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All parens are discarded when there are extra pairs

3 participants

@sosukesuzuki @alexander-akait @duailibe