Fix object trailing commas that last property is ignored#8111
Merged
alexander-akait merged 5 commits intoprettier:masterfrom Apr 25, 2020
Merged
Fix object trailing commas that last property is ignored#8111alexander-akait merged 5 commits intoprettier:masterfrom
alexander-akait merged 5 commits intoprettier:masterfrom
Conversation
fisker
force-pushed
the
issues-5678-prettier-ignore
branch
from
1af3698 to
6972aaa
Compare
fisker
force-pushed
the
issues-5678-prettier-ignore
branch
from
6972aaa to
01769c3
Compare
fisker
changed the title
alexander-akait
approved these changes
Apr 22, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
How about what if I wanted to don't add the trailing comma and use prettier-ignore for that 😄
Good job!
Member
Author
|
I guess you have to add |
Member
Author
fisker
commented
Apr 22, 2020
| foo = { | ||
| _: "", | ||
| // prettier-ignore | ||
| bar: 1 /* comment */, |
Member
Author
There was a problem hiding this comment.
This comment is move from after , to before ,. Array do the same
thorn0
reviewed
Apr 25, 2020
| bar: /* comment */ 1, | ||
| } | ||
|
|
||
| /* RestElement */ |
Member
There was a problem hiding this comment.
This is SpreadElement. Rest is destructuring.
thorn0
approved these changes
Apr 25, 2020
Member
Author
|
I was going to fix that comment... |
Member
|
@fisker oh, sorry, feel free to send a new PR, let's use draft in future 😄 |
fisker
added a commit
to fisker/prettier
that referenced
this pull request
Apr 25, 2020
fisker
added a commit
that referenced
this pull request
Apr 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5678
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨