Revert "Switch parse-srcset to srcset (#7381)"#8359
Merged
fisker merged 3 commits intoprettier:masterfrom May 21, 2020
Merged
Conversation
| "minimist": "1.2.5", | ||
| "n-readlines": "1.0.0", | ||
| "outdent": "0.7.1", | ||
| "parse-srcset": "ikatyang/parse-srcset#54eb9c1cb21db5c62b4d0e275d7249516df6f0ee", |
Member
There was a problem hiding this comment.
What about countries where github banned? They exist 😄
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
To be honestly we should fix it in the future
alexander-akait
approved these changes
May 20, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Anyway let's merge, I have rewritten algorithm in html-loader (based on spec) https://github.com/webpack-contrib/html-loader/blob/master/src/plugins/source-plugin.js#L41, maybe it is time to move it to own package
thorn0
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #7381, Fixes #8150
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨