SCSS: Fix broken comments between declaration prop and value#8366
Merged
lipis merged 9 commits intoprettier:masterfrom Jun 9, 2020
Merged
SCSS: Fix broken comments between declaration prop and value#8366lipis merged 9 commits intoprettier:masterfrom
lipis merged 9 commits intoprettier:masterfrom
Conversation
Member
Author
|
I forgot mark this ready, this not prefect, but prints better. |
# Conflicts: # tests/less/comments/__snapshots__/jsfmt.spec.js.snap
fisker
commented
May 27, 2020
Comment on lines
+215
to
+226
| $font-family-rich: | ||
| // custom | ||
| "Noto Sans TC", "Noto Sans SC", "Noto Sans JP", | ||
| // Safari for OS X and iOS (San Francisco) | ||
| -apple-system, | ||
| BlinkMacSystemFont, | ||
| // fallback | ||
| Roboto, | ||
| "Helvetica Neue", Helvetica, Arial, sans-serif, | ||
| // emoji | ||
| "Apple Color Emoji", | ||
| "Segoe UI Emoji", "Segoe UI Symbol" !default; |
Member
Author
There was a problem hiding this comment.
I know this still ugly, but stable even worse
Prettier 2.0.5
Playground link
--parser scssInput:
$font-family-rich:
// custom
'Noto Sans TC', 'Noto Sans SC', 'Noto Sans JP',
// Safari for OS X and iOS (San Francisco)
-apple-system, BlinkMacSystemFont,
// fallback
Roboto, 'Helvetica Neue', Helvetica, Arial, sans-serif,
// emoji
'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol' !default;Output:
$font-family-rich:
// custom "Noto Sans TC", "Noto Sans SC", "Noto Sans JP",
// Safari for OS X and iOS (San Francisco)
-apple-system,
BlinkMacSystemFont,
// fallback
Roboto,
"Helvetica Neue", Helvetica, Arial, sans-serif,
// emoji
"Apple Color Emoji",
"Segoe UI Emoji", "Segoe UI Symbol" !default;
Member
|
We can improve it in the future, broken code is worse than ugly |
Member
Author
|
Forgot changlog, will add tomorrow. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5603
Fixes #8052
Fixes #7109
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨