Skip to content

Treat <option> and <optgroup> as block#8620

Merged
fisker merged 2 commits intoprettier:masterfrom
fisker:option-block
Jun 24, 2020
Merged

Treat <option> and <optgroup> as block#8620
fisker merged 2 commits intoprettier:masterfrom
fisker:option-block

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Jun 23, 2020

Related: Treat <select> and <optgroup> as inline-block for whitespace sensitivity

I think it's safe to treat option and optgroup as block.
This is how chrome do https://chromium.googlesource.com/chromium/blink/+/refs/heads/master/Source/core/css/html.css

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review June 23, 2020 04:17
Copy link
Copy Markdown
Member

@thorn0 thorn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK what I was thinking when making #8275.

@fisker fisker merged commit 63a37a2 into prettier:master Jun 24, 2020
@fisker fisker deleted the option-block branch June 24, 2020 10:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants