Merged
Conversation
fisker
commented
Jun 23, 2020
| ><param name="autoplay" value="true" /><param | ||
| name="autoplay" | ||
| value="true" /></object | ||
|
|
Member
Author
There was a problem hiding this comment.
This should be a unrelated bug.
thorn0
reviewed
Jun 24, 2020
| track: "block", | ||
| script: "block", | ||
| param: "block", | ||
| noscript: "none", |
Member
There was a problem hiding this comment.
Why none? How is it different from block?
Member
Author
There was a problem hiding this comment.
I need update tests, current example not good.
Member
Author
There was a problem hiding this comment.
none seems same as inline, I'll check if noscript can set to block
Member
Author
There was a problem hiding this comment.
On chrome, <noscript> is inline
alexander-akait
approved these changes
Jun 26, 2020
thorn0
approved these changes
Jul 14, 2020
Member
Author
|
Forgot snapshot outdated, fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨