Skip to content

Handle file paths with whitespace#163

Merged
mitermayer merged 3 commits intoprettier:masterfrom
jason0x43:handle-path-whitespace
Feb 6, 2019
Merged

Handle file paths with whitespace#163
mitermayer merged 3 commits intoprettier:masterfrom
jason0x43:handle-path-whitespace

Conversation

@jason0x43
Copy link
Copy Markdown
Contributor

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, do a sanity check on vim8 and neovim
  3. If you've changed APIs, update the README and documentation ./doc/prettier.txt

Please use the simple form below as a guideline for describing your pull request.

Thanks for contributing to vim-prettier


Summary

Wrap the path used for --stdin-filepath in quotes. This allows prettier to work with files that have whitespace in their paths.

references #108

Test Plan

  1. Edit a file in a location with whitespace in the path (e.g., /Users/jason/Library/Mobile Documents/foo.md).
  2. Run :Prettier.
  3. Verify that prettier runs without error.

Wrap the path used for `stdin-filepath` in quotes.

references prettier#108
@mitermayer
Copy link
Copy Markdown
Member

Thank you! Will test this and merge it ASAP

@mitermayer
Copy link
Copy Markdown
Member

Merging this once builds pass

@mitermayer mitermayer merged commit 0dbe7dc into prettier:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants