Fix markdown mangling issue#169
Merged
mitermayer merged 1 commit intoprettier:masterfrom Jan 15, 2019
Merged
Conversation
|
Fixed #166 locally for me as well. Pinging @premithk as @mitermayer seems to have been offline for a while. |
Contributor
|
Hey @tommilligan. This does seem ok but only @mitermayer can merge this PR. |
Member
|
Thank you for the PR! Sorry for the delay. Just got back to work this week from paternity leave |
Contributor
Author
|
Congrats on baby! |
|
Thanks! Congrats on becoming a dad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin currently mangles markdown. This is because markdown also follows html ftplugins. (See SO Answer)
This has manifested for other users as shown in issue #166
Test Plan
Well, everything now works for both html files and markdown files. I tried only in neovim and without a bunch of different configurations, but I figure this is so remarkably simple it can't fail.