Implement and test GitHub authentication actions#53
Merged
txsmith merged 1 commit intoisApproved-v2from Jun 14, 2017
Merged
Conversation
|
This pull request can be reviewed with Preview Code. |
txsmith
force-pushed
the
github-auth-actions
branch
from
648d913 to
f378d8f
Compare
txsmith
force-pushed
the
github-auth-actions
branch
from
f378d8f to
27a9344
Compare
eanker
added a commit
that referenced
this pull request
Jun 29, 2017
* Added initial version of approvingAPI v2 * Allow users to set the approval status multiple times * Implement getApprovals * Implement and test GitHub authentication actions (#53) * Add tests for getApprovals actions * Added two tests (then stepper was empty) * Test that evaluation of getApproval finishes * Added enpoint for fetching hunk approvals * Added tests for getHunkApprovals * Added javadoc for approvalsAPI * Change all occurrences of Seq to List * Implement DeleteGroup in DatabaseInterpreter * Ensure ApproveStatus is never null * Implement FetchHunksForGroup in DatabaseInterpreter * Make Approvals refer to a hunk by their ID * Constrain hunks to be unique per pull request * Coerce the jOOQ api into handling 'INSERT INTO ... RETURNING ...' queries * Change the database dsl to return entire hunks/approvals * Fix tests for database service * Re-implement hunk and approval fetching * Implement generic deserialization of types with one field * Implement wrapped type serialization * Test wrapped type de/serialization * Implement github authentication actions and a caching interpreter * Import hunks when a PR is opened (#54)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.