Optimise the use case where the two conditions overlap in an =#38
Draft
nterbogt wants to merge 1 commit intopreviousnext:mainfrom
Draft
Optimise the use case where the two conditions overlap in an =#38nterbogt wants to merge 1 commit intopreviousnext:mainfrom
nterbogt wants to merge 1 commit intopreviousnext:mainfrom
Conversation
Author
|
All tests passed on this, but there might be a slight flaw in the math. Putting in Draft until I can review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a special use case where the depth and the start overlap and create SQL that looks like
(a <= x) & (a >= x)... this is equivalent to(a=x)and as a result allows better use of the table indexes, specifically the(id, revision_id, left_pos, right_pos, depth).Before optimisation:
After optimisation: