Fix closing tag position detection when not reading from beginning of file#78
Merged
Merged
Conversation
…ating negative length item to be flushed
Owner
|
Thanks! I'm glad we have tests, it's hard to wrap my head around this parsing at a glance. I'll merge it when I have the chance. |
Owner
|
Merged and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #77
Closing tag position in working blob is being detected no matter the position of the opening one. This creates case where length of string to be flushed might become negative, resulting in flushing all of working blob except x characters, where x is difference in position between opening and closing tag.
This update is made to support seeking through stream without invalid items found.