Skip to content

Double-click binding name to rename#15

Merged
prgmitchell merged 1 commit intoprgmitchell:mainfrom
xal3xhx:feat/dblclick-rename-binding
Apr 18, 2026
Merged

Double-click binding name to rename#15
prgmitchell merged 1 commit intoprgmitchell:mainfrom
xal3xhx:feat/dblclick-rename-binding

Conversation

@xal3xhx
Copy link
Copy Markdown
Contributor

@xal3xhx xal3xhx commented Apr 17, 2026

Summary

  • Double-clicking a binding's name opens the inline rename editor
  • Matches the behavior of the pencil button for button bindings, and bypasses the fader config modal so the name is always what gets edited
  • Cursor and tooltip hint the affordance; user-select: none prevents the text-selection flash on double-click

Implementation

  • src/features/bindings/bindings.jsdblclick listener on the .binding-name label calls beginBindingEdit(binding.id, true) (forceInline = true so faders also rename inline)
  • src/styles/bindings-and-panels.css.binding-name gets cursor: text and user-select: none

Test plan

  • Double-click a button binding's name — input appears, rename commits on blur/enter
  • Double-click a fader binding's name — same inline rename (no fader config modal)
  • Single-click still does nothing / does not enter edit mode
  • Pencil button still works as before (fader → config modal, button → rename)
  • No text-selection flash on double-click

Double-clicking a binding's name now opens the inline rename editor, the
same action as the pencil button for button bindings. Cursor and tooltip
hint the affordance; user-select suppressed to avoid text-selection flash.
@prgmitchell prgmitchell merged commit 5042f1e into prgmitchell:main Apr 18, 2026
1 check passed
@xal3xhx xal3xhx deleted the feat/dblclick-rename-binding branch April 18, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants