Merged
Conversation
This reverts commit 4f3c043.
cpiemontese
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting #40. As discussed in this Slack thread, that PR changed
from_avro_mapso it no longer errors when fields are missing from the target struct. This broketry_decodefor union types when decoding records made entirely of nullable fields.A possible fix would be to update
try_decodeto verify the record actually contains the fields it’s about to decode before callingfrom_avro_map. For now, reverting is the safest way to restore the previous behaviour and unblock decoding.