[PLATFORM-1237]: Minimize oci image size#61
Merged
cottinisimone merged 9 commits intomasterfrom Oct 6, 2023
Merged
Conversation
Contributor
|
This is really cool (I'll leave a proper review to someone else because I don't feel qualified) |
MaeIsBad
reviewed
Oct 6, 2023
Member
MaeIsBad
left a comment
MaeIsBad
left a comment
There was a problem hiding this comment.
Everything seems great. One small question but I think we can merge this 🚀
| @@ -0,0 +1 @@ | |||
| target No newline at end of file | |||
Member
There was a problem hiding this comment.
We don't need this right? Shouldn't docker use .gitignore by default?
Contributor
Author
There was a problem hiding this comment.
It seems not since it was copied in the context while building the image
MaeIsBad
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1237
At the end this is the final size of the built image. If you have other suggestions feel free to propose :).