Fix Calendar displaying value when controlled state is not updated #8457
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Calendar displays incorrect value when controlled value is not updated
Problem
When the Calendar component is used as a controlled component, it updates its input field optimistically on date selection.
If the parent component intentionally does not update the
valueinonChange(e.g. user cancels a confirmation dialog), the input temporarily displays an incorrect date.Solution
props.valueThis restores proper controlled component behavior and fixes issue #7428.
Reproducer
https://codesandbox.io/p/sandbox/primereact-calendar-displays-incorrect-value-if-new-value-was-not-applied-in-onchange-sw2547
Calendar: incorrect value is displayed #7428