[Feature Request] Allow re-ordering of `socialLinks` in `MinimalFooter`

[simurai]

Problem

Currently when trying to customize the <MinimalFooter> by adding socialLinks, the order has no effect and seems predefined.

<MinimalFooter
    socialLinks={['linkedin', 'instagram', 'youtube', 'x', 'tiktok', 'twitch', 'github']}
>

Suggestion

It would be nice if the order in the socialLinks array would honor the order how the icons appear. So that for example it could match the order of https://github.com/home

---

This came up in https://github.com/github/githubuniverse.com/issues/2176 (internal)

[joshfarrant]

This makes sense to me. The only question I'd have is what would happen if you didn't pass a particular link? Eg if you didn't pass TikTok — would it just be omitted?

That approach could cause problems if we were to add another social link in the future as it would then be omitted from any page which explicitly specifies the socialLinks prop.

In that case, we'd probably be better off appending any links which aren't explicitly listed in the socialLinks array to the end of list, so any new links will just be added to the end even if they're not explicitly listed.

[simurai]

@joshfarrant Eg if you didn't pass TikTok — would it just be omitted?

Yes. I think that's how it already works now. E.g. in the above example, Facebook is omitted and doesn't show up.

That approach could cause problems if we were to add another social link in the future as it would then be omitted from any page which explicitly specifies the socialLinks prop.

Hmm.. good point. 🤔 If this is a concern, we kinda need two props? Like..

• socialLinksOrder Here you can set the order of the icons
• socialLinksExcluded Here you can omit any icons you don't want to show up.

Then if an icon is not part of either prop, it will just be appended at the end.

But not sure.. if that complicates everything. The "what happens to future additions" might be low priority? And PM/designers will tell us if something is missing.

[raytalks]

@rezrah Can you please take a look at this issue, so Simon can move forward with Universe LP? 🙏🏽

[joshfarrant]

@raytalks @rezrah I'm happy to pick this up as I'm currently working on the following a11y issues relating to MinimalFooter, so I can add this while I'm in there.

• https://github.com/github/primer/issues/3732
• https://github.com/github/primer/issues/3733