[Feedback] React components should support `style` prop

[iansan5653]

The React Octicon components support the className prop, which makes it easy to apply custom styles to them. However, sometimes class-based styling is insufficient, such as when you need a fully dynamic style. For this, the style attribute is very important.

An example of its use might be when defining a dynamic icon color:

<SparkleFillIcon style={{color: ...}} />

[langermank]

Hey @iansan5653, do you think the fill option could work for this? Here's an example: https://primer-6b9ae9b407-13348165.drafts.github.io/storybook/?path=/story/octicons--fill

[iansan5653]

I think that does work for this specific problem. I still think that for consistency with other React components, it would be useful to support className styling we should also support inline styling via style. It's handy to have.

[tallys]

hey @iansan5653 thanks for opening the issue. We're not able to prioritize this at this time, but I will add it to our backlog for consideration when we revisit.

[github-actions]

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.