Merged
Conversation
🦋 Changeset detectedLatest commit: dae9342 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Design Token Diff (CSS)The message is too long to be displayed here. For more details, please check the job summary. |
Contributor
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Contributor
Design Token Diff (Figma)
|
Contributor
Design Token Diff (Fallbacks)
|
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates design-token documentation and adds/extends several token definitions (border, button, size/spacing), and changes the duration/css Style Dictionary transformer to always emit CSS durations in milliseconds.
Changes:
- Updated
durationToCsstransformer to convert seconds to milliseconds and always outputms; adjusted unit tests accordingly. - Added new spacing tokens (e.g.
paddingInline.condensed,paddingInline.spacious,controlStack.*.gap.auto) across size token files, including fine/coarse variants. - Clarified token documentation and added new semantic border/button tokens (e.g.
border.translucent,border.draft.*, button disabled fgColor tokens, plus additional descriptions).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/transformers/durationToCss.ts | Standardizes duration CSS output to milliseconds by converting s to ms. |
| src/transformers/durationToCss.test.ts | Updates expectations to match ms-only output behavior. |
| src/tokens/functional/size/size.json5 | Adds additional control padding variants and controlStack auto gap tokens. |
| src/tokens/functional/size/size-fine.json5 | Adds controlStack.large.gap.auto for fine pointer contexts. |
| src/tokens/functional/size/size-coarse.json5 | Adds controlStack.large.gap.auto for coarse pointer contexts. |
| src/tokens/functional/size/radius.json5 | Refines radius documentation for borderRadius.large. |
| src/tokens/functional/color/borderColor.json5 | Adds top-level guidance clarifying borderColor as color-only and updates translucent description. |
| src/tokens/functional/border/border.json5 | Clarifies composite border token guidance; adds translucent and draft border shorthand tokens. |
| src/tokens/component/button.json5 | Adds disabled fgColor tokens and improves documentation for single-state variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukasoppermann
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new tokens and clarifies documentation across several token files, focusing on border, button, and spacing tokens. It also standardizes the CSS transformer for durations to always output milliseconds. The most important changes are grouped below: