Skip to content

[TEST] Update base and display color scales#1340

Closed
danielguillan wants to merge 0 commit intomainfrom
danielguillan/update-brand-refactor-scales
Closed

[TEST] Update base and display color scales#1340
danielguillan wants to merge 0 commit intomainfrom
danielguillan/update-brand-refactor-scales

Conversation

@danielguillan
Copy link
Copy Markdown

@danielguillan danielguillan commented Mar 30, 2026 •
edited
Loading

Please see #1369

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e67d1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026 •
edited
Loading

Design Token Diff (CSS)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026 •
edited
Loading

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026 •
edited
Loading

Design Token Diff (Figma)

The message is too long to be displayed here. For more details, please check the job summary.

@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 30, 2026 16:25 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 30, 2026 17:45 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 30, 2026 18:05 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 30, 2026 20:09 Inactive
@danielguillan danielguillan added the update snapshots Update visual regression test snapshots label Mar 30, 2026
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Mar 30, 2026
@primer primer Bot temporarily deployed to github-pages March 30, 2026 22:49 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 30, 2026 22:50 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) March 31, 2026 14:32 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 22, 2026 09:56 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 22, 2026 14:47 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 22, 2026 16:17 Inactive
@danielguillan danielguillan force-pushed the danielguillan/update-brand-refactor-scales branch from 7ed3f88 to a53de07 Compare April 23, 2026 07:41
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 23, 2026 07:44 Inactive
@danielguillan danielguillan added the update snapshots Update visual regression test snapshots label Apr 23, 2026
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Apr 23, 2026
@primer primer Bot temporarily deployed to github-pages April 23, 2026 10:15 Inactive
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 23, 2026 10:16 Inactive
@danielguillan danielguillan added the update snapshots Update visual regression test snapshots label Apr 23, 2026
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 23, 2026 15:42 Inactive
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Apr 23, 2026
@danielguillan danielguillan added the update snapshots Update visual regression test snapshots label Apr 28, 2026
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Apr 28, 2026
@github-actions github-actions Bot temporarily deployed to Preview (Storybook) April 28, 2026 13:25 Inactive
This was referenced Apr 29, 2026
Closed
Closed
lukasoppermann added a commit that referenced this pull request Apr 30, 2026
@lukasoppermann
fix: Update scale comparison HTML with correct colors and improved la…
32e6be5 
…yout

- Use actual PR #1340 green-gray colors (not original blue-gray)
- New side-by-side layout: labels on outside, swatches touching in middle
- Larger color swatches (100px height) for better comparison
- Direct visual comparison: left half is PR #1340, right half is hybrid
- Hover effects for interactivity
- Hex codes displayed below step labels on each side
lukasoppermann added a commit that referenced this pull request Apr 30, 2026
@lukasoppermann
fix: Update scale comparison to show 18-step monotonic proposal
cd8cbd7 
- Remove separation line between colors (seamless swatch)
- Replace 14+2 approach with 18-step monotonic scale
- Insert steps BETWEEN existing ones instead of extending at ends
- Maintains monotonic progression (never gets lighter)
- Fixes emphasis color contrast issues
- Shows mapping from PR #1340 (14 steps) to proposed (18 steps)
- Highlights inserted steps that improve contrast flexibility

Key insight: Scale should always darken, never lighten. Insert internal steps
to smooth gradations and provide better emphasis color options.

Emphasis mapping example:
- bgColor-neutral-emphasis: step 8 → step 14
- Contrast: 1.64:1 → ~8:1 (WCAG AAA passed)
lukasoppermann added a commit that referenced this pull request Apr 30, 2026
@lukasoppermann
fix: Show ALL 18 steps clearly (no more missing steps)
362cb98 
- Single unified view showing all 18 steps (0-17)
- Clear badges: [FROM PR #1340] vs [INSERTED]
- No confusing mapping sections or hidden steps
- All 18 steps visible and comparable
- Better explanation of why inserts between are better than extends at ends

Fixes issue where steps appeared to be missing.
lukasoppermann added a commit that referenced this pull request Apr 30, 2026
@lukasoppermann
design: Gray out inserted steps on left side for clarity
5369c55 
- Inserted steps (2,3,5,7,9,11,13,15) now grayed on left
- FROM PR #1340 steps have normal blue labels
- Makes it visually clear which steps are new vs preserved
- Improves readability of scale composition
@lukasoppermann lukasoppermann mentioned this pull request Apr 30, 2026
Closed
@lukasoppermann lukasoppermann force-pushed the danielguillan/update-brand-refactor-scales branch from 1e3ed4e to 2e67d1b Compare April 30, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielguillan @lukasoppermann