Deprecate shadow-floating-legacy and reduce floating-small border alpha#1345
Merged
lukasoppermann merged 3 commits intomainfrom Apr 10, 2026
Merged
Deprecate shadow-floating-legacy and reduce floating-small border alpha#1345lukasoppermann merged 3 commits intomainfrom
lukasoppermann merged 3 commits intomainfrom
Conversation
- Add $deprecated pointing to shadow.floating.small on shadow.floating.legacy - Reduce overlay.borderColor alpha from 0.5 to 0.25 on shadow.floating.small (light mode) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 63e158f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Design Token Diff (CSS)
|
Contributor
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Contributor
Design Token Diff (Figma)
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Primer shadow tokens to (1) soften the light-mode border component of shadow.floating.small, and (2) mark shadow.floating.legacy as deprecated with shadow.floating.small as the suggested replacement.
Changes:
- Reduced the
{overlay.borderColor}alpha used inshadow.floating.smallfrom0.5to0.25(base/light value). - Added
$deprecated: '{shadow.floating.small}'toshadow.floating.legacy.
Show a summary per file
| File | Description |
|---|---|
| src/tokens/functional/shadow/shadow.json5 | Adjusts light-mode floating-small border alpha and adds a deprecation pointer for the legacy floating shadow token. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
approved these changes
Apr 8, 2026
Collaborator
Author
|
@copilot remove the legacy shadow all together and update the changeset, as all usage has been removed with those 4 PRs: |
Agent-Logs-Url: https://github.com/primer/primitives/sessions/f6959d55-7fc2-4676-a992-e460b9399d9a Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
Contributor
Done in 63e158f — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/github/core-ux/issues/2052
Summary
Shadow Opacity Adjustment:
alphavalue from 0.5 to 0.25 for a shadow, making the shadow more subtle.Token Deprecation:
legacyshadow token as deprecated, referencing the{shadow.floating.small}token as its replacement.