Improve npm script naming and fix issues#1353
Merged
lukasoppermann merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Renames: - build:config → build:types - validate:contrast → check:contrast - format:fix → format, format → format:check - install:storybook → storybook:install, start:storybook → storybook Fixes: - Remove double clean (prebuild already handles it) - Add --max-warnings=0 to lint script - Fix double-space typo in format command - Normalize ./scripts/ → scripts/ path prefixes Additions: - Add check script (lint + format:check + test + build) Updates all references in CI workflows and docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: ec31b12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
liuliu-dev
approved these changes
Apr 17, 2026
Agent-Logs-Url: https://github.com/primer/primitives/sessions/4b237951-0d97-409a-aa06-ba330885460b Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up npm script names for consistency and fixes several small issues.
Renames
build:configbuild:typestscand copies typesvalidate:contrastcheck:contrastcheck:prefixformat(check)format:checkformat:fix(write)formatinstall:storybookstorybook:installstorybook:prefixstart:storybookstorybookFixes
buildcallednpm run cleanbutprebuildalready doesrm -rf dist— removed the redundant call--max-warnings=0: Added tolint(was only onlint:fix, which is backwards)./scripts/→scripts/Additions
checkscript: single command forlint + format:check + test + buildUpdated references
All CI workflows and contributor docs updated to use the new names.