Skip to content

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Dec 4, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@36.4.0

Minor Changes

  • #3982 968d4ef05 Thanks @joshblack! - Update SSRProvider, useSSRSafeId to use the native React 18 useId() instead of @react-aria/ssr

  • #3812 3f82a1cab Thanks @mperrotti! - Adds an 'inactive' state to buttons. An inactive button looks disabled and has aria-disabled, but it can still be clicked and focused. This was added to support buttons that are broken due to availability issues, but can't be removed from the page.

Patch Changes

@primer primer bot requested review from a team and mperrotti December 4, 2023 18:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.81 KB (0%)
dist/browser.umd.js 105.34 KB (0%)

@primer primer bot temporarily deployed to github-pages December 4, 2023 18:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 4, 2023 18:10 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 0c9e5e7 to 3a52050 Compare December 4, 2023 18:51
@primer primer bot temporarily deployed to github-pages December 4, 2023 18:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 4, 2023 18:57 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 3a52050 to 974f0ae Compare December 4, 2023 22:24
@primer primer bot temporarily deployed to github-pages December 4, 2023 22:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 4, 2023 22:28 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 974f0ae to 978f2ae Compare December 5, 2023 13:48
@primer primer bot temporarily deployed to github-pages December 5, 2023 13:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 5, 2023 13:54 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 978f2ae to 963ca40 Compare December 5, 2023 15:27
@primer primer bot temporarily deployed to github-pages December 5, 2023 15:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 5, 2023 15:31 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 963ca40 to de51ce5 Compare December 5, 2023 17:22
@primer primer bot temporarily deployed to github-pages December 5, 2023 17:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 5, 2023 17:29 Inactive
@primer primer bot force-pushed the changeset-release/main branch from de51ce5 to 714ae48 Compare December 5, 2023 19:00
@primer primer bot temporarily deployed to github-pages December 5, 2023 19:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 5, 2023 19:05 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 714ae48 to 5fc5b99 Compare December 5, 2023 22:37
@primer primer bot temporarily deployed to github-pages December 5, 2023 22:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 5, 2023 22:42 Inactive
@siddharthkp siddharthkp mentioned this pull request Dec 6, 2023
4 tasks
@primer primer bot force-pushed the changeset-release/main branch from 5fc5b99 to 9f574b0 Compare December 6, 2023 14:41
@primer primer bot temporarily deployed to github-pages December 6, 2023 14:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 6, 2023 14:46 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New PR merged, integration tests are now failing 😢

@primer primer bot force-pushed the changeset-release/main branch from 9f574b0 to 0110124 Compare December 6, 2023 16:08
@github-actions github-actions bot requested a review from siddharthkp December 6, 2023 16:09
@primer primer bot force-pushed the changeset-release/main branch from 0110124 to 9a2494f Compare December 6, 2023 16:13
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 6, 2023 16:14 Inactive
@primer primer bot temporarily deployed to github-pages December 6, 2023 16:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 6, 2023 16:18 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 9a2494f to 094e50a Compare December 6, 2023 17:15
@primer primer bot temporarily deployed to github-pages December 6, 2023 17:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4016 December 6, 2023 17:19 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now!

Details in #4010

@siddharthkp siddharthkp added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 48fd418 Dec 7, 2023
@siddharthkp siddharthkp deleted the changeset-release/main branch December 7, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant