Skip to content

Change is to as #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2019
Merged

Change is to as #524

merged 1 commit into from
Aug 19, 2019

Conversation

@urre
Copy link
Contributor

@urre urre commented Aug 17, 2019

Change description of the details components usage of Button to toggle the visibility.

colebemis
colebemis approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the PR, @urre! 🎉

emplums
emplums approved these changes Aug 19, 2019
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@emplums emplums merged commit ce13f53 into primer:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@colebemis colebemis colebemis approved these changes

@emplums emplums emplums approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@urre @colebemis @emplums