Add muted prop to Link. #567
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-components-git-muted-link.primer.now.sh |
| @@ -1,4 +1,3 @@ | |||
| import loadable from '@loadable/component' | |||
There was a problem hiding this comment.
Fixes a lint warning
| appearance: 'none' | ||
| } | ||
|
|
||
| const hoverColor = system({ |
There was a problem hiding this comment.
I'm not really sure what this was doing. I couldn't find any color emitted for :hover on the links. It seems like for normal links the color is the same on hover, but if this needs to be added back for another reason, let me know!
There was a problem hiding this comment.
This adds a custom styled system prop to the component so that users of the component can configure what color the links should be on hover. I think we should put this back in - there were a few places where we were changing the hover color intentionally - I believe the primer.style site still uses it!
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
Just made one suggestion otherwise this looks good!
Co-Authored-By: Emily <emplums@github.com>
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
This is good to go! If you can just bump the version we can merge & release :)
Updated
Linkto accept amutedprop to achieve the styles found here: https://primer.style/css/utilities/colors#link-colorsCloses #561