Skip to content

Update data table pagination pageEnd to handle zero based index #5913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AAugustine merged 6 commits into from
Apr 14, 2025
Merged

Update data table pagination pageEnd to handle zero based index #5913

AAugustine merged 6 commits into from
Apr 14, 2025

Conversation

@AAugustine
Copy link
Contributor

@AAugustine AAugustine commented Apr 10, 2025 •
edited by francinelucca
Loading

Closes #5909

Changelog

New

A test that specifically tests the failing case on when the total count is 1 + pageSize

Changed

Changed how pageEnd was being calculated. It now makes pageEnd represent the actual display rather than a zero-based index.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 264dbf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.7 KB (0%)
packages/react/dist/browser.umd.js 102.99 KB (0%)

@AAugustine AAugustine marked this pull request as ready for review April 10, 2025 20:12
@AAugustine AAugustine requested a review from a team as a code owner April 10, 2025 20:12
@AAugustine AAugustine requested a review from jonrohan April 10, 2025 20:12
@github-actions github-actions bot temporarily deployed to storybook-preview-5913 April 10, 2025 20:14 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 10, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5913 April 10, 2025 21:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5913 April 11, 2025 19:39 Inactive
@primer-integration
Copy link

primer-integration bot commented Apr 14, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/372530

@primer-integration
Copy link

primer-integration bot commented Apr 14, 2025

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 14, 2025
hectahertz
hectahertz approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! TYSM for the contribution!

@hectahertz hectahertz enabled auto-merge April 14, 2025 14:47
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 14, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5913 April 14, 2025 20:18 Abandoned
@francinelucca francinelucca disabled auto-merge April 14, 2025 20:44
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5913 April 14, 2025 22:56 Inactive
@AAugustine AAugustine added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit abb4bd3 Apr 14, 2025
40 checks passed
@AAugustine AAugustine deleted the table-pagination-bug-fix branch April 14, 2025 23:31
@primer primer bot mentioned this pull request Apr 14, 2025
Merged
TylerJDev pushed a commit that referenced this pull request Apr 17, 2025
@AAugustine @francinelucca @TylerJDev
Update data table pagination pageEnd to handle zero based index (#5913)
b926c08 
Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
hectahertz pushed a commit that referenced this pull request May 20, 2025
@AAugustine @francinelucca @hectahertz
Update data table pagination pageEnd to handle zero based index (#5913)
2090c53 
Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hectahertz hectahertz hectahertz approved these changes

@francinelucca francinelucca francinelucca approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Paginated data table pagination range bug

4 participants

@AAugustine @hectahertz @francinelucca