Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Apr 11, 2025

Add a new internal component, BoxWithFallback, to help with using Box if an sx prop is provided but falling back to a base element if no sx prop is provided.

Changelog

New

  • Add new internal component, BoxWithFallback

Changed

  • Update components that create a base component with toggleSxComponent to use BoxWithFallback diretcly

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is an refactor with an internal component

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 869a737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.2 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 104.53 KB (-0.02% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5919 April 11, 2025 17:09 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Apr 11, 2025
@joshblack joshblack marked this pull request as ready for review April 11, 2025 17:12
@joshblack joshblack requested a review from a team as a code owner April 11, 2025 17:12
@github-actions github-actions bot requested a deployment to storybook-preview-5919 April 11, 2025 17:14 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5919 April 11, 2025 17:28 Inactive
@joshblack joshblack added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
@joshblack joshblack added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit c130cc4 Apr 15, 2025
44 checks passed
@joshblack joshblack deleted the refactor/add-box-with-fallback branch April 15, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants