Skip to content

Conversation

@jonrohan
Copy link
Member

This cleans up some of the tests in the components that use CSS modules feature flags even after the component has shipped fully or is on a different feature flag.

I went though each test and verified the component is fully shipped or off of the staff feature flag.

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Apr 14, 2025
@jonrohan jonrohan requested a review from a team as a code owner April 14, 2025 17:52
@jonrohan jonrohan requested a review from francinelucca April 14, 2025 17:52
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: fa2b2ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan enabled auto-merge April 14, 2025 17:52
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 14, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.7 KB (0%)
packages/react/dist/browser.umd.js 102.99 KB (0%)

@jonrohan jonrohan added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 74fd6d9 Apr 14, 2025
44 checks passed
@jonrohan jonrohan deleted the cleanup_feature_flag_tests branch April 14, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants