[FIX] updates Button small variant padding#682
Merged
Conversation
• resolves issue 681
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/gylvkrq5j |
alanbsmith
commented
Feb 3, 2020
| const variants = variant({ | ||
| variants: { | ||
| small: { | ||
| p: '3px 10px', |
Contributor
Author
There was a problem hiding this comment.
I saw other components, like TextInput, use separate px and py props, but this directly replaced the padding in buttonStyles. Happy to update it if you'd like though.
simurai
added
ds-triaged
fr-skip
This was referenced Feb 4, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• resolves issue
Describe your changes here.
Closes #681
Screenshots
Gatsby docs running in Chrome:
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contibuting guidelines for more infomation on how we review PRs.